Date: Thu, 4 Jan 2024 11:29:31 +0200
Steve Downey via SG15 <sg15_at_[hidden]> writes:
> And presumably the json would point at the same interface files, but
> provide asan flags.
I am actually not sure the modules manifest providing the ASAN flags
is the best option. In particular, this doesn't make sure that the
entire codebase is built with ASAN flags (e.g., C++ code that don't
use modules, C code). Perhaps a better option is for the build system
to provide the ASAN flags when querying for the modules manifest and
the compiler returning the path to the appropriate manifest or no path
if the user options don't match standard library options? I've touched
on this here:
https://github.com/llvm/llvm-project/issues/73089#issuecomment-1857368730
https://github.com/llvm/llvm-project/issues/73089#issuecomment-1857532968
> And presumably the json would point at the same interface files, but
> provide asan flags.
I am actually not sure the modules manifest providing the ASAN flags
is the best option. In particular, this doesn't make sure that the
entire codebase is built with ASAN flags (e.g., C++ code that don't
use modules, C code). Perhaps a better option is for the build system
to provide the ASAN flags when querying for the modules manifest and
the compiler returning the path to the appropriate manifest or no path
if the user options don't match standard library options? I've touched
on this here:
https://github.com/llvm/llvm-project/issues/73089#issuecomment-1857368730
https://github.com/llvm/llvm-project/issues/73089#issuecomment-1857532968
Received on 2024-01-04 12:00:11