C++ Logo

sg7

Advanced search

Re: Update: P1240R2 — Scalable Reflection - Typos

From: Matus Chochlik <chochlik_at_[hidden]>
Date: Tue, 1 Feb 2022 06:39:35 +0100
Hi,

p.27:
consteval auto rankinfo type)->int {...};
should be(?):
consteval auto rank(info type)->int {...};

On Mon, Jan 31, 2022 at 11:34 PM Daveed Vandevoorde via SG7 <
sg7_at_[hidden]> wrote:

>
>
> > On Jan 30, 2022, at 7:47 AM, Jonathan O'Connor via SG7 <
> sg7_at_[hidden]> wrote:
> >
> > Hi everyone,
> > this is the first of a few emails on P1240R2. I've divided up my
> comments on the paper into more useful chunks, rather than including them
> in a single email.
> >
> > Page 9, 3rd code block, 3rd line of comment about `^0`:
> > "is a" should be deleted as it is at the end of 2nd comment line.
>
> Thanks!
>
> >
> > Page 25, 4th code block:
> > ```c++
> > ^std::make_signed<typename(r)>::type /* missing splicer */
> > ```
> > should be
> > ```c++
> > ^std::make_signed<[:typename(r):]>::type /* missing splicer */
> > ```
>
> Thanks! (That syntax was what was proposed in earlier versions.)
>
>
> >
> > Page 27, first code block:
> > The rank function is missing a parens before info.
>
> Yep. (That one was fixed in our version already.)
>
> >
> > Page 31, second code block:
> > The `is_pralue()` call is missing a 'v' -> `is_prvalue`
>
> Nice catch, thanks!
>
> >
> > Page 33, in paragraph after second code block:
> > "parent_of returns the a reflection" should be "parent_of returns the
> reflection"
>
> Thanks!
>
> >
> > Page 37, second code block, third line:
> > What is `s.idexpr`?
>
> It’s an old form of the splicer syntax. I apparently missed that instance
> of it when updating for P2320.
>
> Thanks again!
>
> Daveed
>
>
> >
> > Regards,
> > Jonathan
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On Saturday, January 15th, 2022 at 17:41, Daveed Vandevoorde via SG7 <
> sg7_at_[hidden]> wrote:
> >
> >> SG7 mailing list
> >>
> >> SG7_at_[hidden]
> >>
> >> https://lists.isocpp.org/mailman/listinfo.cgi/sg7
> > --
> > SG7 mailing list
> > SG7_at_[hidden]
> > https://lists.isocpp.org/mailman/listinfo.cgi/sg7
>
> --
> SG7 mailing list
> SG7_at_[hidden]
> https://lists.isocpp.org/mailman/listinfo.cgi/sg7
>

Received on 2022-02-01 05:39:47