C++ Logo

sg16

Advanced search

Re: Review comments for P2845R2: Formatting of std::filesystem::path

From: Victor Zverovich <victor.zverovich_at_[hidden]>
Date: Sat, 26 Aug 2023 08:42:47 -0700
Hi Tom,

Thanks for reviewing the paper. The first issue has already been reported
by Roger Orr and fixed in https://isocpp.org/files/papers/D2845R3.html.
Regarding the second issue, I'll double check the escaping rules and fix
the example or the text accordingly.

Cheers,
Victor

On Fri, Aug 25, 2023 at 8:30 PM Tom Honermann via SG16 <
sg16_at_[hidden]> wrote:

> I reviewed the changes in P2845R2 (Formatting of std::filesystem::path)
> <https://wg21.link/p2845r2> and spotted what I think are a couple of
> errors with the lone surrogate examples near the end of section 5,
> "Proposal".
>
> First, both examples are actually identical. I think one of them should
> have {:?} as the replacement field.
>
> Second, for the escaped example, it is stated that hexadecimal escapes are
> produced, but the example output is presented as "\u{d800}"; I think that
> should be "\x{d800}".
>
> Tom.
> --
> SG16 mailing list
> SG16_at_[hidden]
> https://lists.isocpp.org/mailman/listinfo.cgi/sg16
>

Received on 2023-08-26 15:43:00