Date: Wed, 14 Aug 2019 21:11:35 -0700
On Wednesday, 14 August 2019 20:43:48 PDT Tom Honermann wrote:
> Does MSVC only complain when the /validate-charset option is enabled?
No. See the issue as reported:
https://bugreports.qt.io/browse/QTBUG-56155
That's MSVC 2015 without the /utf-8 option. It's a warning about *comment*.
But we compile our sources with -WX to ensure we don't miss any warnings,
which meant that it became a hard error in our CI.
And it's good that we do, because that warning mojibake, as intended, in
https://bugreports.qt.io/browse/QTBUG-58161
> Does MSVC only complain when the /validate-charset option is enabled?
No. See the issue as reported:
https://bugreports.qt.io/browse/QTBUG-56155
That's MSVC 2015 without the /utf-8 option. It's a warning about *comment*.
But we compile our sources with -WX to ensure we don't miss any warnings,
which meant that it became a hard error in our CI.
And it's good that we do, because that warning mojibake, as intended, in
https://bugreports.qt.io/browse/QTBUG-58161
-- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel System Software Products
Received on 2019-08-15 06:11:38