Date: Tue, 18 Jun 2019 18:01:09 +0300
Turned out that the whole “code examples” section was completely wrong as the code examples given were still on an old version of the API. So they wouldn’t even compile. Let’s treat that as a glitch in the matrix ;)
Please find attached the fixed R2.
Cheers,
Timur
> On 18 Jun 2019, at 17:50, Timur Doumler via SG13 <sg13_at_[hidden]> wrote:
>
> Update:
>
>> On 18 Jun 2019, at 17:29, Timur Doumler via SG13 <sg13_at_[hidden] <mailto:sg13_at_[hidden]>> wrote:
>>>
>>> 7. 7.1/7.3 the while(true); is ihmo UB. Could we make it while(device.has_unprocessed_io()); or similarly check the state of it.
>>
>> Also correct. Will fix.
>
> I fixed this, however while(device.has_unprocessed_io()); would be the wrong condition if you do async processing (the normal case). Better to use while(device.is_running()). This way the loop will stop as soon as the device becomes unavailable or the user stops it.
>
> Cheers,
> Timur
>
> --
> SG13 mailing list
> SG13_at_[hidden]
> http://lists.isocpp.org/mailman/listinfo.cgi/sg13
Please find attached the fixed R2.
Cheers,
Timur
> On 18 Jun 2019, at 17:50, Timur Doumler via SG13 <sg13_at_[hidden]> wrote:
>
> Update:
>
>> On 18 Jun 2019, at 17:29, Timur Doumler via SG13 <sg13_at_[hidden] <mailto:sg13_at_[hidden]>> wrote:
>>>
>>> 7. 7.1/7.3 the while(true); is ihmo UB. Could we make it while(device.has_unprocessed_io()); or similarly check the state of it.
>>
>> Also correct. Will fix.
>
> I fixed this, however while(device.has_unprocessed_io()); would be the wrong condition if you do async processing (the normal case). Better to use while(device.is_running()). This way the loop will stop as soon as the device becomes unavailable or the user stops it.
>
> Cheers,
> Timur
>
> --
> SG13 mailing list
> SG13_at_[hidden]
> http://lists.isocpp.org/mailman/listinfo.cgi/sg13
Received on 2019-06-18 10:03:05