Date: Fri, 4 Oct 2019 22:35:20 +0300
On Fri, 4 Oct 2019 at 21:51, Richard Smith via Core
<core_at_[hidden]> wrote:
> For __cpp_nodiscard_reason: I'm opposed to adding this macro in isolation. Either we need to accept that version numbers for feature test macros don't work (the magic numbers are too magical) and completely rethink our approach, or we do not have adequate rationale for this.
Agreed. Testing the value of __has_cpp_attribute already provides for
this particular feature test.
The other comments of yours also seemed quite reasonable to me.
<core_at_[hidden]> wrote:
> For __cpp_nodiscard_reason: I'm opposed to adding this macro in isolation. Either we need to accept that version numbers for feature test macros don't work (the magic numbers are too magical) and completely rethink our approach, or we do not have adequate rationale for this.
Agreed. Testing the value of __has_cpp_attribute already provides for
this particular feature test.
The other comments of yours also seemed quite reasonable to me.
Received on 2019-10-04 21:35:35